Skip to content

Enable CoreCLR/tvOS build #111804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025
Merged

Enable CoreCLR/tvOS build #111804

merged 4 commits into from
Apr 29, 2025

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Jan 24, 2025

Gets far enough to run the Hello World sample in tvOS Simulator:

image

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 24, 2025
Comment on lines +638 to +651
(void)!write(STDERR_FILENO, StackOverflowMessage, sizeof(StackOverflowMessage) - 1);
PROCAbort(SIGSEGV, siginfo);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This likely needs to be resolved in a different way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like tvOS just cannot handle stack overflow gracefully. We probably would not even get this far.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think tvOS could hit this path. I assume it uses the exception port mechanism instead of signals like macOS, or am I mistaken?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tvOS doesn't expose Mach exceptions and neither does it expose sigaltstack. The PR basically enables the code paths for POSIX signals there without the alternative stack. Mono is using the same configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's surprising, ok.

@filipnavara filipnavara added the os-tvos Apple tvOS label Jan 24, 2025
Copy link
Contributor

Tagging subscribers to 'os-tvos': @vitek-karas, @kotlarmilos, @ivanpovazan, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@ivanpovazan
Copy link
Member

/azp run runtime-ioslike

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@filipnavara filipnavara reopened this Apr 27, 2025
@filipnavara filipnavara marked this pull request as ready for review April 28, 2025 12:29
@filipnavara filipnavara requested a review from janvorli April 29, 2025 05:39
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit b32d486 into dotnet:main Apr 29, 2025
96 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
@filipnavara filipnavara deleted the coreclr-tvos branch June 5, 2025 06:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member os-tvos Apple tvOS
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants