Simplify conditional operator #112074
Simplify conditional operator #112074
Conversation
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
|
They were originally written like that to mitigate some CQ issue. I believe they have been fixed in RyuJIT now but I'm not sure about mono. |
It seems base and diff are compiled to identical IL (sharplab) |
| @@ -314,12 +314,12 @@ internal static object DefaultToType(IConvertible value, Type targetType, IForma | |||
| // Conversions to Boolean | |||
| public static bool ToBoolean([NotNullWhen(true)] object? value) | |||
| { | |||
| return value == null ? false : ((IConvertible)value).ToBoolean(null); | |||
| return value != null && ((IConvertible)value).ToBoolean(null); | |||
There was a problem hiding this comment.
These could be value is IConvertible convertible && convertible.ToBoolean(null), yes?
There was a problem hiding this comment.
This could be a change in behavior?
There was a problem hiding this comment.
Certainly a change in code generation, arguably for the worse: https://csharp.godbolt.org/z/nrM7df3YP
There was a problem hiding this comment.
What makes you say it's "worse"?
The code is nearly identical, just without the early exit for null.
src/libraries/System.Private.CoreLib/src/System/Collections/Hashtable.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-meta |
am11
removed
the
needs-area-label
Simplify conditional operator in
src/coreclr/System.Private.CoreLib/System.Private.CoreLib.sln