Skip to content

[wasm][coreclr] Make libs subset build #114548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 25, 2025

Conversation

radekdoulik
Copy link
Member

No description provided.

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@radekdoulik radekdoulik marked this pull request as ready for review April 14, 2025 13:02
radekdoulik and others added 2 commits April 14, 2025 17:42
…owser.cs

Co-authored-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
@steveisok
Copy link
Member

I don't think this is a blocker, but building on windows fails super quick. Likely some batch tweaks so the right things get passed to cmake.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radekdoulik radekdoulik merged commit 16260fb into dotnet:main Apr 25, 2025
146 of 150 checks passed
@radekdoulik
Copy link
Member Author

I don't think this is a blocker, but building on windows fails super quick. Likely some batch tweaks so the right things get passed to cmake.

#115058 should improve it

@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants