Make specifying just DllImportSearchPath.AssemblyDirectory only search in assembly directory
#114756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
added
area-System.Runtime.InteropServices
breaking-change
elinor-fung
requested review from
jkoritzinsky,
MichalStrehovsky,
AaronRobinsonMSFT and
Copilot
elinor-fung
requested review from
thaystg,
steveisok and
vitek-karas
as code owners
dotnet-policy-service
bot
added
the
needs-breaking-change-doc-created
There was a problem hiding this comment.
Pull Request Overview
This PR updates the runtime behavior so that specifying only DllImportSearchPath.AssemblyDirectory limits native library lookup to the assembly directory without falling back to OS search paths. Key changes include:
- Updating tests to validate the no-fallback scenario.
- Propagating a new user-specified flag in the native library lookup code across mono, coreclr, and NativeAOT.
- Adjusting function signatures and conditional logic to differentiate explicit from default search flag behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.cs | Updated test name and assertions to verify no fallback to OS search. |
| src/mono/mono/metadata/native-library.c | Modified function signatures and conditions to track user-specified flags. |
| src/coreclr/vm/nativelibrary.cpp | Updated API and inline logic to separately pass user-specified flag information. |
| src/coreclr/nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.cs | Adjusted method signatures and parameter handling to propagate the new flag. |
| src/coreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/InteropHelpers.cs | Passed the additional flag for DllImportSearchPath in helper functions. |
|
Tagging subscribers to this area: @dotnet/interop-contrib |
This was referenced Apr 18, 2025
Open
AaronRobinsonMSFT
approved these changes
Apr 20, 2025
...tiveaot/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
elinor-fung
commented
Apr 23, 2025
...tiveaot/System.Private.CoreLib/src/System/Runtime/InteropServices/NativeLibrary.NativeAot.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update coreclr, mono, and nativeaot to treat specifying only
DllImportSearchPath.AssemblyDirectoryas only searching the assembly directory - no fallback to the OS search behaviour.Since the default behaviour (search assembly directory and then fall back to the OS search) is represented with the same flags/values as if the user specified only
DllImportSearchPath.AssemblyDirectory, this implementation tracks whether the flags were user-specified.Fixes #107040