-
Notifications
You must be signed in to change notification settings - Fork 5k
Implementation for UnsafeAccessorTypeAttribute
#114881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AaronRobinsonMSFT
merged 68 commits into
dotnet:main
from
AaronRobinsonMSFT:unsafeaccessortype_impl
May 13, 2025
Merged
Implementation for UnsafeAccessorTypeAttribute
#114881
AaronRobinsonMSFT
merged 68 commits into
dotnet:main
from
AaronRobinsonMSFT:unsafeaccessortype_impl
May 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit currently only contains support for CoreCLR.
…insonMSFT/runtime into unsafeaccessortype_impl
Note regarding the
|
1 similar comment
Note regarding the
|
/cc @AndriySvyryd |
jkotas
reviewed
Apr 22, 2025
jkotas
reviewed
Apr 22, 2025
…insonMSFT/runtime into unsafeaccessortype_impl
sbomer
reviewed
May 12, 2025
jkotas
approved these changes
May 12, 2025
2 tasks
@jkoritzinsky @sbomer Looks like there is an issue with the new linker test.
|
I ran the tests for ILLink but not ILC. I'll fix that. |
I consider this PR complete, just updated the API documentation. Additional suggestions on what to add to the doc are welcome. |
...es/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorTypeAttribute.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
approved these changes
May 13, 2025
jkotas
reviewed
May 13, 2025
...es/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorTypeAttribute.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 13, 2025
...es/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorTypeAttribute.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 13, 2025
...es/System.Private.CoreLib/src/System/Runtime/CompilerServices/UnsafeAccessorTypeAttribute.cs
Outdated
Show resolved
Hide resolved
/ba-g deadletter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90081
Example:
Assembly
A
Assembly
B
- no metadata reference to assemblyA