Enlarge stack overflow handling stack #114956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix rare failures in the stack overflow tests that I was unable to repro locally. The logs I've added so far seems to indicate that the thread handling the exception crashes with another stack overflow at the point when it waits for a secondary thread to finish dumping stack trace.
| @@ -206,7 +206,7 @@ BOOL SEHInitializeSignals(CorUnix::CPalThread *pthrCurrent, DWORD flags) | |||
| } | |||
|
|
|||
| // Allocate the minimal stack necessary for handling stack overflow | |||
| int stackOverflowStackSize = ALIGN_UP(sizeof(SignalHandlerWorkerReturnPoint), 16) + 8 * 4096; | |||
| int stackOverflowStackSize = ALIGN_UP(sizeof(SignalHandlerWorkerReturnPoint), 16) + 9 * 4096; | |||
There was a problem hiding this comment.
Please add an inline comment explaining why the additional 4096 bytes (9 pages) are now required, to aid future maintainers in understanding the rationale behind this change.
Copilot uses AI. Check for mistakes.
This was referenced Apr 23, 2025
jkotas
approved these changes
Apr 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix rare failures in the stack overflow tests that I was unable to repro locally. The logs I've added so far seems to indicate that the thread handling the exception crashes with another stack overflow at the point when it waits for a secondary thread to finish dumping stack trace.