Add single-file host tests for native library load #115061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces single-file host tests for native library loading by adding new test cases and helper functions for both P/Invoke and NativeLibrary API loading.
- Added new switch cases in Program.cs to invoke native library loading functions.
- Implemented the LoadNativeLibrary class with methods for P/Invoke and API-based loading.
- Developed XUnit tests in NativeLibraries.cs to verify the native library load behavior.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/installer/tests/Assets/Projects/HelloWorld/Program.cs | Added cases to trigger native library loading via P/Invoke and API. |
| src/installer/tests/Assets/Projects/HelloWorld/LoadNativeLibrary.cs | Introduced native library load functions including P/Invoke wrappers and API usage. |
| src/installer/tests/AppHost.Bundle.Tests/NativeLibraries.cs | Created XUnit tests to validate native library loading in various modes. |
|
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov |
elinor-fung
commented
Apr 25, 2025
| .Should().Pass() | ||
| .And.CallPInvoke(null, true) | ||
| .And.CallPInvoke(DllImportSearchPath.AssemblyDirectory, true) | ||
| // Single-file always looks in application directory, even when only System32 is specified |
AaronRobinsonMSFT
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @dotnet/appmodel @AaronRobinsonMSFT