Skip to content

Delete redundant gcc-toolchain flag #115073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

Delete redundant gcc-toolchain flag #115073

merged 1 commit into from
Apr 26, 2025

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 26, 2025

Fixes this warning during the smoke tests build:

2025-04-26T02:51:48.2072524Z clang : warning : argument unused during compilation: '--gcc-toolchain=/crossrootfs/x64/usr' [-Wunused-command-line-argument] [/runtime/src/tests/nativeaot/CustomMain/CustomMain.csproj] [/runtime/src/tests/build.proj]

(the second occurrence of --gcc-toolchain is considered "unused")

It predates the consolidation work and it is now a duplicate of:

<CustomLinkerArg Condition="'$(CrossBuild)' == 'true' and '$(_hostArchitecture)' == '$(_targetArchitecture)' and '$(_hostOS)' != 'windows'" Include="--gcc-toolchain=$(ROOTFS_DIR)/usr" />

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 26, 2025
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 4dfeb95 into dotnet:main Apr 26, 2025
77 checks passed
@am11 am11 deleted the patch-31 branch April 26, 2025 05:41
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants