[release/8.0-staging] [STJ] Account for F# CompilationMappingAttribute now supporting multiple declarations. #115077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
added
the
Servicing-consider
jeffhandley
approved these changes
May 8, 2025
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #114961 to release/980-staging
/cc @eiriktsarpalis
Customer Impact
An breaking change to F# version 9.0.300 has introduced a regression in the handling of F# types in System.Text.Json. Rather than rolling back the F# change, we have decided to apply compensating changes to the System.Text.Json code.
Regression
dotnet/fsharp#18274
Testing
Added regression testing covering the impacted scenario.
Risk
Low. The fix trivially extends the attribute querying logic to account for the possibility of multiple attributes of the same type being present.