Skip to content

Test /etc/os-release existence before grepping #115086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 27, 2025

Fix grep: /crossrootfs/arm64/etc/os-release: No such file or directory

during the smoke tests build: https://github.com/am11/CrossRepoCITesting/actions/runs/14681685023/job/41205102419

It is not a fatal error (because of IgnoreExitCode="true") but it shows up in FreeBSD crossbuild logs, where /crossrootfs/arm64/etc/os-release is a symlink to /crossrootfs/arm64/var/run/os-release, latter of which doesn't exist in rootfs environment. The added test makes sure file exists before the search op.

@am11 am11 requested a review from MichalStrehovsky as a code owner April 27, 2025 02:23
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 27, 2025
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
Copy link
Member

jkotas commented Apr 27, 2025

/ba-g deadletter

@jkotas jkotas merged commit 0d20f9a into dotnet:main Apr 27, 2025
96 of 98 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants