Skip to content

Enable SVE2 instruction set detection for ARM64 #115117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025

Conversation

snickolls-arm
Copy link
Contributor

Initial patch for enablement of SVE2 APIs. Allows the CLR to detect the SVE2 feature and adds an InstructionSet to the JIT.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 28, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 28, 2025
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@snickolls-arm
Copy link
Contributor Author

@a74nh

@kunalspathak
Copy link
Member

@dotnet/jit-contrib @dotnet/arm64-contrib

@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Apr 28, 2025
@@ -19,6 +19,10 @@
#define PF_ARM_SVE_INSTRUCTIONS_AVAILABLE (46)
#endif

#ifndef PF_ARM_SVE2_INSTRUCTIONS_AVAILABLE
#define PF_ARM_SVE2_INSTRUCTIONS_AVAILABLE (47) // ref SDK 10.0.26100.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to keep this comment around?

@kunalspathak
Copy link
Member

@snickolls-arm - seems there is merge conflict in jiteeversionguid.h. Can you sync, resolve merge conflict and address 1 comment I made. It should be good to go after that.

Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit d23f251 into dotnet:main May 9, 2025
158 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants