Skip to content

Fix the value of MethodImplOptions.Async in spec #115126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

filipnavara
Copy link
Member

Use the value approved in the API review

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 28, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 28, 2025
@filipnavara filipnavara requested a review from VSadov April 28, 2025 20:35
@teo-tsirpanis teo-tsirpanis added area-Meta and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 28, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@VSadov
Copy link
Member

VSadov commented Apr 28, 2025

Thanks!

The document is a bit behind the feature right now. The HoistedLocal is no longer a thing, FromRuntimeAsync was dropped from the names...

There was a PR with some more cleanups in that document, but the feature was progressing faster than the PR, so there was always something more to add to the PR.

@filipnavara
Copy link
Member Author

The HoistedLocal is no longer a thing

There's other PR tracking that specifically. I know this is not the only update but I felt like it's worth fixing before everyone forgets about it.

@jkotas jkotas merged commit 4e04761 into dotnet:main Apr 28, 2025
18 of 20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta community-contribution Indicates that the PR has been added by a community member runtime-async
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants