[cDAC] IXCLRDataStackWalk::GetContext returns proper HResult #115157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR updates the behavior of IXCLRDataStackWalk::GetContext so that it returns HResult.S_FALSE when the current frame is invalid. Key changes include:
- Introducing a new field (_currentFrameIsValid) to track frame validity.
- Adjusting the GetContext method to conditionally return S_FALSE when no valid frame is present.
- Updating the StackWalk contract to yield no result if the frame is invalid.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataStackWalk.cs | Added _currentFrameIsValid and modified GetContext and Next methods to determine and use frame validity. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.cs | Switched to a FrameIterator and added an early exit (yield break) when the frame is invalid. |
max-charlamb
added
area-Diagnostics-coreclr
and removed
needs-area-label
|
Tagging subscribers to this area: @tommcdon |
|
/ba-g Test failures are unrelated to changes in this PR. Bypassing due to known issue with Build Analysis hanging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IXCLRDataStackWalk::GetContextshould returnHResult.S_FALSEwhen the current Frame is invalid. Previously, this method would return the initial state withHResult.S_OK, triggering a Debug Assert when comparing to the DAC implementation.