Fix passing flags in single-file tests for NativeLibrary.TryLoad #115173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the single-file tests where incorrect flags were passed to NativeLibrary.TryLoad.
- Changed the third parameter in the TryLoad API call from null to the provided flags.
- Ensures that the intended flag values are used for loading native libraries.
Comments suppressed due to low confidence (1)
src/installer/tests/Assets/Projects/HelloWorld/LoadNativeLibrary.cs:43
- Passing the correct flags instead of null fixes the expected behavior, but please verify that 'flags' is always set correctly when this function is called.
bool success = NativeLibrary.TryLoad(name, typeof(LoadNativeLibrary).Assembly, flags, out _);
elinor-fung
added
area-Single-File
and removed
needs-area-label
|
Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov |
AaronRobinsonMSFT
approved these changes
Apr 30, 2025
|
Should a test be failing in this case? |
Not yet. Because we currently always look in the app directory regardless of the flags, the tests are expected to pass. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed at passing the correct flags in tests added in #115061. 🤦