Replace NET6_0 with NET #115209
Replace NET6_0 with NET #115209
Conversation
ghost
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
| @@ -23,7 +23,7 @@ public IpcSocket(AddressFamily addressFamily, SocketType socketType, ProtocolTyp | |||
| } | |||
|
|
|||
| // .NET 6 implements this method directly on Socket, but for earlier runtimes we need a polyfill | |||
| #if !NET6_0_OR_GREATER | |||
| #if !NET | |||
There was a problem hiding this comment.
@ViktorHofer it was outdated because project is netcoreapp3.1
There was a problem hiding this comment.
This looks like shared among multiple repos given the GitHubRepositoryName condition.
There was a problem hiding this comment.
diagnostics and runtime. diagnostics also uses netstandard2 and current sdk for projects. netcoreapp3.1 has been out of support for years
.../FunctionalTests/Android/Device_Emulator/gRPC/grpc-dotnet/testassets/Shared/InteropClient.cs
Show resolved
Hide resolved
ViktorHofer
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
|
Yeah, diagnostics owns it. If you'd like this change to be out there, it needs to go in the diagnostics repo. That being said, this change is correct and benign. |
|
I looked at the diagnostics code and it already diverged a bit from this (uses NET8) but I agree this is harmless to take here. |
|
/ba-g Build analysis got stuck |
|
@akoeplinger there is one more project using ancient tfm #115373 |
No description provided.