Skip to content

Fix Metadata aggregator: removing cumulative sum for GUIDs heap offset #115268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −2
Open

Fix Metadata aggregator: removing cumulative sum for GUIDs heap offset #115268

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
55e1080
metadata aggregator: removing cumulative sum for GUIDs heap
fabrimaz May 3, 2025
03e6cb9
Merge branch 'main' into fix/113910
fabrimaz May 4, 2025
6ab179c
Edit to _heapSizes object comment
fabrimaz May 10, 2025
1ccfa80
Merge branch 'fix/113910' of https://github.com/fabrimaz/DotNetRuntim…
fabrimaz May 10, 2025
f842df6
Merge branch 'main' into fix/113910
fabrimaz May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/System.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/MetadataAggregator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ private static ImmutableArray<ImmutableArray<int>> CalculateHeapSizes(
userStringSizes[r + 1] = userStringSizes[r] + deltaReaders[r].GetHeapSize(HeapIndex.UserString);
stringSizes[r + 1] = stringSizes[r] + deltaReaders[r].GetHeapSize(HeapIndex.String);
blobSizes[r + 1] = blobSizes[r] + deltaReaders[r].GetHeapSize(HeapIndex.Blob);
guidSizes[r + 1] = guidSizes[r] + deltaReaders[r].GetHeapSize(HeapIndex.Guid) / guidSize;
guidSizes[r + 1] = deltaReaders[r].GetHeapSize(HeapIndex.Guid) / guidSize;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line https://github.com/dotnet/runtime/pull/115268/files#diff-463bcba9d713f9c49493793a38b92567be4f344112abe18ebd08a34d3a5a1659R13 should be updated

}

return ImmutableArray.Create(
Expand Down
Loading