Skip to content

Add UrlFormat to PQC Experimental attribute #115412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

Add UrlFormat to PQC Experimental attribute #115412

merged 1 commit into from
May 9, 2025

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented May 8, 2025

We missed the UrlFormat property on the PQC attributes. Per @jeffhandley, this does not block preview 4.

@vcsjones vcsjones added this to the 10.0.0 milestone May 8, 2025
@vcsjones vcsjones requested review from bartonjs and Copilot May 8, 2025 21:13
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot
Copilot AI reviewed May 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vcsjones vcsjones mentioned this pull request May 8, 2025
Merged
@vcsjones vcsjones merged commit 59a5ce1 into dotnet:main May 9, 2025
83 of 87 checks passed
@vcsjones vcsjones deleted the pqc-experimental-attr-fix branch May 9, 2025 02:58
This was referenced May 9, 2025
Open
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@jeffhandley jeffhandley jeffhandley approved these changes

@bartonjs bartonjs bartonjs approved these changes

Assignees

@vcsjones vcsjones

Labels
area-System.Security
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vcsjones @jeffhandley @bartonjs