[9.0] Fix line endings

[richlander]

• Bad line endings got into the repo.
• This creates a unix-style enlistment more challenging to use (git reset --hard doesn't work)
• Similar to: Fix line ending #114171.

Before this change:

$ git ls-files --eol | grep '\.cs' | grep crlf
i/crlf  w/crlf  attr/text               src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/IncreaseMetadataRowSize.cs
i/crlf  w/crlf  attr/text               src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/IncreaseMetadataRowSize_v1.cs
i/crlf  w/crlf  attr/text               src/libraries/System.Runtime.Loader/tests/ApplyUpdate/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize/System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize.csproj

After this change:

$ git ls-files --eol | grep '\.cs' | grep crlf
$

Perhaps this line is wrong?

https://github.com/dotnet/runtime/blob/8ac2c2877ce98d9b28949a3beb717524b5e6e31b/.gitattributes#L30C1-L30C22

Should it be changed to the following?

*.cs text eol=lf diff=csharp

[Copilot]

Pull Request Overview

This PR fixes inconsistent line endings that caused issues for Unix-style enlistments. The changes normalize line endings across several test project files.

• Updated the .csproj file for ApplyUpdate tests.
• Normalized line endings in IncreaseMetadataRowSize_v1.cs and IncreaseMetadataRowSize.cs.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
System.Reflection.Metadata.ApplyUpdate.Test.IncreaseMetadataRowSize.csproj	Adjusted line endings to Unix-style formatting.
IncreaseMetadataRowSize_v1.cs	Normalized line endings and preserved code logic/formatting.
IncreaseMetadataRowSize.cs	Normalized line endings with no functional changes.

[tomap]

Also, the .EditorConfig does not specify the line ending for most files:
https://github.com/dotnet/runtime/blob/release/9.0-staging/.editorconfig#L189

[richlander]

Good point. Let's merge these PRs as-is and then develop a new standard for these configuration files to force LF that can be used as a pattern in other repos. Is there someone who can volunteer to do that?

This isn't the first case I've seen of line ending confusion. It suspect most people are using Windows so they don't notice this.

[vcsjones]

This looks familiar, and was in #114190 (comment)

But I think that was only fixed for main, not 9.0.

Ultimately, some people have configured their git client to do disable auto crlf and that made its way in. It doesn't matter what gitattributes is set to.

[richlander]

That doesn't stop us from having good configuration and documenting the preferred client config, right?

[vcsjones]

Should it be changed to the following?
*.cs text eol=lf diff=csharp

That means you would be checking out files locally on Windows with LF, not CRLF line endings and I think that would massively confuse folks that checkout the runtime on Windows.

Also, the .EditorConfig does not specify the line ending for most files:

Likewise, that would be forcing one OS's line ending opinions on another. Changing the editorconfig to LF would mean Windows would prefer using LF locally.

[jkotas]

That doesn't stop us from having good configuration and documenting the preferred client config, right?

We used to have a section in the documentation that talked about how to clone a repo, but we dropped it since it is github 101 topic that is covered much better elsewhere.

Our .gitattributes is setup to make the default git client config to do the right thing. You do not need to worry about line endings if you use vanilla git workflow.

For mistakes like this to happen, one has to use advanced custom configs, like running multiple OSes side-by-side with shared file system or manually copying files between different OSes.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

[jkotas]

Tell mode