Move Untracked_Release to native code to avoid problems during shutdown #115489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR moves the implementation of untracked COM reference counting from managed to native code to avoid problems during process shutdown. Key changes include:
- Updating ReferenceTrackerHost.cs to call a native provider for AddRef/Release.
- Removing managed implementations of Untracked_AddRef/Untracked_Release from ComWrappers.cs.
- Adding native implementations and entrypoints in multiple interop and runtime files.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| System/Runtime/InteropServices/ReferenceTrackerHost.cs | Updated to use native function pointers via GetUntrackedIUnknownImpl |
| System/Runtime/InteropServices/ComWrappers.cs | Removed managed implementations of untracked ref counting |
| vm/qcallentrypoints.cpp | Added entries for native untracked AddRef/Release |
| vm/interoplibinterface_comwrappers.h | Declared native functions for untracked AddRef/Release |
| vm/interoplibinterface_comwrappers.cpp | Defined native implementations for untracked AddRef/Release and exposed them |
| nativeaot/System.Private.CoreLib/src/System/Runtime/RuntimeImports.cs | Added extern declaration for RhUntracked_Release |
| nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/TrackerObjectManager.NativeAot.cs | Updated to use the native GetUntrackedIUnknownImpl pattern |
| nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.NativeAot.cs | Added a native GetUntrackedIUnknownImpl method to acquire function pointers |
| nativeaot/Runtime/HandleTableHelpers.cpp | Implemented native RhUntracked_Release to avoid GC transitions during shutdown |
| System/Runtime/InteropServices/ComWrappers.CoreCLR.cs | Added native imports for untracked AddRef/Release |
|
Tagging subscribers to this area: @dotnet/interop-contrib |
src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 12, 2025
...nativeaot/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.NativeAot.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 12, 2025
jkotas
approved these changes
May 12, 2025
AaronRobinsonMSFT
approved these changes
May 12, 2025
|
/ba-g failures unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115460
Fixes #115462