throw an exception instead of infinite loop in sort_mark_list
#115492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maoni0
changed the title
sort_mark_list
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a critical infinite loop issue observed in sort_mark_list due to heap corruption by introducing an exception mechanism when an invalid (zero) region limit is encountered.
- Adds a check for a zero region limit and terminates using FATAL_GC_ERROR() instead of entering an infinite loop.
- Updates the core garbage collection routine to improve production diagnostics when encountering freed regions.
Comments suppressed due to low confidence (1)
src/coreclr/gc/gc.cpp:10798
- Consider verifying that FATAL_GC_ERROR() provides sufficient diagnostic context for production debugging, potentially by enhancing the error message or logging detailed information.
if (region_limit == 0)
|
Tagging subscribers to this area: @dotnet/gc |
Maoni0
force-pushed
the
crash_instead_of_loop
branch
from
f1d09c4 to
059365a
Compare
mangod9
reviewed
May 13, 2025
| // simply throwing an exception. | ||
| if (region_limit == 0) | ||
| { | ||
| FATAL_GC_ERROR(); |
There was a problem hiding this comment.
should we log something here to mention that its probably a heap corruption?
mangod9
approved these changes
May 13, 2025
|
/backport to release/8.0-staging |
|
/backport to release/9.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15006087166 |
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15006088865 |
This was referenced May 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had a customer who observed an infinite loop in
sort_mark_listdue to heap corruption - the object that got marked was in a region that was already freed soregion_limitis 0. we detect this and throw an exception which is easier for prod diag than having to deal with an infinite loop.