[WIP] Interpreter boxing/unboxing #115549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
BrzVlad
reviewed
May 14, 2025
am11
reviewed
May 14, 2025
Fix unbox_any pushing VT unconditionally instead of pushing the appropriate interp type
janvorli
approved these changes
May 15, 2025
kg
added a commit
to kg/runtime
that referenced
this pull request
May 16, 2025
* Introduce box/unbox/unbox_any opcodes into the interpreter * Interpreter name normalization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds interp opcodes for box, unbox, and unbox_any. The interpreter compiler looks up the appropriate helper ftn for the operation in question at compile time and then we invoke the helper to perform the actual box/unbox operation.
Also refactors a couple inconsistent names in the interpreter (MethodDesc/MethodToken -> MethodHandle)