Normalize the paths to ensure install works on newer versions of cmake #115571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC. @elinor-fung |
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR normalizes Windows install paths using CMake’s file(TO_CMAKE_PATH) to ensure environment variables are interpreted correctly on CMake v4.0+ and updates the CRT file globbing to use the normalized paths.
- Normalize
VCToolsRedistDirandExtensionSdkDirwithfile(TO_CMAKE_PATH) - Update
file(GLOB_RECURSE ...)patterns to reference the new normalized variables
Comments suppressed due to low confidence (1)
src/native/corehost/test/ijw/CMakeLists.txt:16
- Consider adding a check to ensure $ENV{VCToolsRedistDir} is defined (e.g.,
if(NOT DEFINED ENV{VCToolsRedistDir}) ...) before callingfile(TO_CMAKE_PATH)to fail early if the environment variable is missing.
file(TO_CMAKE_PATH "$ENV{VCToolsRedistDir}" CMAKE_VS_VCTOOLSREDISTDIR)
Comment on lines
15
to
+16
| # Copy over the debug CRT so that it is available for test runs | ||
| file(TO_CMAKE_PATH "$ENV{VCToolsRedistDir}" CMAKE_VS_VCTOOLSREDISTDIR) |
There was a problem hiding this comment.
[nitpick] Add a brief comment explaining that file(TO_CMAKE_PATH) is used to normalize Windows paths (transform backslashes to forward slashes) for compatibility with CMake 4.0+.
Suggested change
| # Copy over the debug CRT so that it is available for test runs | |
| file(TO_CMAKE_PATH "$ENV{VCToolsRedistDir}" CMAKE_VS_VCTOOLSREDISTDIR) | |
| # Copy over the debug CRT so that it is available for test runs | |
| # Normalize the Windows path (transform backslashes to forward slashes) for compatibility with CMake 4.0+ | |
| file(TO_CMAKE_PATH "$ENV{VCToolsRedistDir}" CMAKE_VS_VCTOOLSREDISTDIR) | |
| # Normalize the Windows path (transform backslashes to forward slashes) for compatibility with CMake 4.0+ |
Copilot uses AI. Check for mistakes.
tannergooding
added
area-Infrastructure-installer
and removed
needs-area-label
This was referenced May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken yesterday in #114187
On some versions of CMake (potentially just v4.0.0 and later) the install will fail as
C:\Program Filesis interpreted as containing an escape character\Pwhich is unrecognized.