-
Notifications
You must be signed in to change notification settings - Fork 5k
[LoongArch64] Fix NativeAOT libs.tests failed cases in System.Runtime.Tests & System.Runtime.Numerics.Tests. #115598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…System.Runtime.Numerics.Tests. * Fix the boundary error with `imm = (~0)` for `Unsigned GT_LE/GT_GT` in `CodeGen::genCodeForCompare()`. * Fix the IntCastOverflowPositiveCheck with `UINT32_MAX` in `CodeGen::genIntCastOverflowCheck()`. * Optimize `CodeGen::genIntCastOverflowCheck()` similar to riscv.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jakobbotsch , could you please review this PR?
The boundary failed testcases in NAOT-libs.tests of failed testcases in NAOT-System.Runtime.Tests
failed testcases in NAOT-System.Runtime.Numerics.Tests
Fixed: |
imm+1
whenimm = (~0)
forUnsigned GT_LE/GT_GT
inCodeGen::genCodeForCompare()
.UINT32_MAX
inCodeGen::genIntCastOverflowCheck()
.CodeGen::genIntCastOverflowCheck()
similar to riscv.