Fix runtime build with -msbuild flag #115606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the runtime build issue when using the -msbuild flag by resolving file name conflicts between CachedInterfaceDispatch variants.
- Renames CachedInterfaceDispatchCoreclr.cpp to CachedInterfaceDispatch_Coreclr.cpp in the VM sources.
- Renames CachedInterfaceDispatchAot.cpp to CachedInterfaceDispatch_Aot.cpp in the NativeAOT runtime sources.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/CMakeLists.txt | Renamed CachedInterfaceDispatchCoreclr.cpp to CachedInterfaceDispatch_Coreclr.cpp to fix name conflicts. |
| src/coreclr/nativeaot/Runtime/CMakeLists.txt | Renamed CachedInterfaceDispatchAot.cpp to CachedInterfaceDispatch_Aot.cpp to fix name conflicts. |
github-actions
bot
added
the
needs-area-label
|
PTAL @jkoritzinsky @dotnet/jit-contrib if any of you use |
|
Fixes #113708 |
Ah, I didn't see that one. Looks like what I've done here was suggested there in #113708 (comment) |
jkoritzinsky
approved these changes
May 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CachedInterfaceDispatchCoreclr.cppandCachedInterfaceDispatchCoreclr.asmforced cmake to produce a vcxproj with changed object names (.o) forCachedInterfaceDispatchCoreclr.asmdue to name conflict - it then failed to pick it up. Same forCachedInterfaceDispatchAot.I renamed the .cpp versions to fix the build -
build.cmd -msbuildwas effectively broken.