Revert "[RuntimeAsync] ilasm/ildasm support for the MethodImpl.Async" #115621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previously added support for the async MethodImpl attribute in both ilasm and ildasm, restoring the prior state before #115332.
- Removes
asynckeyword definition from il_kywd.h - Stops emitting
asyncin ildasm output - Deletes
asyncparsing rules from the ilasm grammar
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/inc/il_kywd.h | Removed KYWD("async", ASYNC_, NO_VALUE) entry |
| src/coreclr/ildasm/dasm.cpp | Removed IsMiAsync emission for " async" |
| src/coreclr/ilasm/prebuilt/asmparse.grammar | Removed async from implAttr alternatives |
| src/coreclr/ilasm/asmparse.y | Deleted ASYNC_ token and its grammar branch |
|
Tagging subscribers to this area: @JulieLeeMSFT |
ViktorHofer
approved these changes
May 15, 2025
VSadov
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #115332