JIT: Skip extra SPMI queries when we don't know the exact type #115637
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the SPMI query logic by guarding extra queries with a check for a precise type to avoid unnecessary work.
- Added an extra condition in the SPMI query on stack allocated arrays.
- Updated comments to reflect the new behavior regarding precise type checks.
| // | ||
| if (JitConfig.EnableExtraSuperPmiQueries()) | ||
| if (JitConfig.EnableExtraSuperPmiQueries() && !eeIsSharedInst(resolvedToken.hClass)) |
There was a problem hiding this comment.
Consider expanding the comment to clarify what qualifies as a 'precise type' and what constitutes a shared instance, to improve maintainability and clarity.
Copilot uses AI. Check for mistakes.
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. I think this is the right guard -- collecting NativeAOT smoke tests locally doesn't hit asserts anymore -- but let me know if I need something broader. Thanks! |
|
/ba-g NativeAOT build timeout, and dead-lettered test |
Fixes #114934.