Rename collectPerfCounters to collectMetrics in browser runtime #115926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
linkable-framework
pavelsavara
added
arch-wasm
pavelsavara
removed
the
linkable-framework
dotnet-policy-service
bot
added
the
linkable-framework
Co-authored-by: pavelsavara <271576+pavelsavara@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
pavelsavara
May 23, 2025 06:52
pavelsavara
removed
the
linkable-framework
|
@ copilot search whole repository for |
Co-authored-by: pavelsavara <271576+pavelsavara@users.noreply.github.com>
Found and updated the remaining instance of |
There was a problem hiding this comment.
Pull Request Overview
This PR renames the JavaScript API from collectPerfCounters to collectMetrics to more accurately reflect the metrics collected in the browser runtime, aligning the API name with its cross-platform functionality.
- Renamed the API in documentation (features.md)
- Updated type definitions and API exports (index.ts, export-api.ts)
- Modified internal imports and function calls to use the new name (diagnostics/index.ts, dotnet-counters.ts, diagnostics-js.ts)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mono/wasm/features.md | Updated example usage to reflect the new function name |
| src/mono/browser/runtime/types/index.ts | Renamed API type definition from collectPerfCounters to collectMetrics |
| src/mono/browser/runtime/export-api.ts | Updated API export property from collectPerfCounters to collectMetrics |
| src/mono/browser/runtime/diagnostics/index.ts | Fixed internal diagnostic mapping for the new API name |
| src/mono/browser/runtime/diagnostics/dotnet-counters.ts | Renamed the function from collectPerfCounters to collectMetrics |
| src/mono/browser/runtime/diagnostics/diagnostics-js.ts | Updated import and function call to use collectMetrics |
maraf
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
collectPerfCountersJavaScript API tocollectMetricsto better reflect what it's collecting.Why the change?
Performance Counters were a Windows-specific .NET Framework feature (docs), but in later versions of .NET, they were replaced with a cross-platform Metrics model (docs).
The JS API was originally named after the older Windows-specific feature, but it's actually collecting the modern cross-platform metrics that can be used on any platform. The new name more accurately reflects the functionality.
Changes made
src/mono/browser/runtime/diagnostics/dotnet-counters.tsFixes #115472.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.