Skip to content

Simplify findvcvarsall.bat #115951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2025
Merged

Simplify findvcvarsall.bat #115951

merged 2 commits into from
May 24, 2025

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented May 23, 2025

Delete unnecessary version check

@jkotas
Simplify findvcvarsall.bat
112a272 
Delete unnecessary version check
@Copilot Copilot AI review requested due to automatic review settings May 23, 2025 19:26
@jkotas jkotas requested a review from MichalStrehovsky as a code owner May 23, 2025 19:26
Copilot
Copilot AI reviewed May 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the findvcvarsall.bat script by removing the version constraint on the Visual Studio tools lookup.

  • Deleted the -version [16,18^) filter in the vswhere invocation.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas requested a review from jkoritzinsky May 23, 2025 19:28
@jkotas jkotas mentioned this pull request May 24, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request May 24, 2025
Open
3 tasks
@jkotas
Copy link
Member Author

jkotas commented May 24, 2025

/ba-g known issue #115955

@jkotas jkotas merged commit c00b15f into dotnet:main May 24, 2025
90 of 93 checks passed
@jkotas jkotas deleted the simplify branch May 24, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

@jkoritzinsky jkoritzinsky

@MichalStrehovsky MichalStrehovsky

Assignees

@jkotas jkotas

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @jkoritzinsky