Fix cmake warning #116000
Merged
Fix cmake warning #116000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the endif comment in configureplatform.cmake to match the full conditional and eliminate a CMake warning.
- Expanded the
endifcomment to include bothemscriptenandbrowser. - Resolves mismatch between
ifandendifconditions causing the warning.
github-actions
bot
added
the
needs-area-label
radekdoulik
removed
the
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
filipnavara
approved these changes
May 26, 2025
| @@ -437,7 +437,7 @@ endif(CLR_CMAKE_TARGET_OS STREQUAL haiku) | |||
| if(CLR_CMAKE_TARGET_OS STREQUAL emscripten OR CLR_CMAKE_TARGET_OS STREQUAL browser) | |||
| set(CLR_CMAKE_TARGET_UNIX 1) | |||
| set(CLR_CMAKE_TARGET_BROWSER 1) | |||
| endif(CLR_CMAKE_TARGET_OS STREQUAL emscripten) | |||
| endif(CLR_CMAKE_TARGET_OS STREQUAL emscripten OR CLR_CMAKE_TARGET_OS STREQUAL browser) | |||
There was a problem hiding this comment.
We can also change this to not have the condition repeated.
Suggested change
| endif(CLR_CMAKE_TARGET_OS STREQUAL emscripten OR CLR_CMAKE_TARGET_OS STREQUAL browser) | |
| endif() |
There was a problem hiding this comment.
Yes, but that would make it inconsistent with the rest of the file.
There was a problem hiding this comment.
I never liked the repeated condition but I agree this should be made in a different PR if we were to change it
akoeplinger
approved these changes
May 27, 2025
|
/ba-g unrelated infrastructure issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115998