JIT: Always intersect exception sets of defs #116007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic would only intersect the exception sets of subsequent defs if it had also seen a use. That meant for a list of DEF, DEF, USE CSEs candidates we would only validate that the first def's exception sets were sufficient for the use.
github-actions
bot
added
the
area-CodeGen-coreclr
jakobbotsch
commented
May 27, 2025
src/tests/JIT/Regression/JitBlue/Runtime_112848/Runtime_112848.csproj
Outdated
Show resolved
Hide resolved
AndyAyersMS
approved these changes
May 27, 2025
I haven't dug in to check if some of those are actual bugs or not. Since this logic isn't aware of reaching defs it is overly conservative. It seems like we could insert into SSA earlier to make use of that information for this check. |
|
Forgot to cc @dotnet/jit-contrib. Diffs are mainly regressions where we no longer CSE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic would only intersect the exception sets of subsequent defs if it had also seen a use. That meant for a list of [DEF, DEF, USE] CSE candidates we would only validate that the first def's exception set was sufficient for the use.
Fix #112848