Skip to content

[RuntimeAsync] Disable building async tests on configurations that are not yet supported. #116084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented May 29, 2025

Test-only change to disable building async tests on configurations that are not yet supported.

@Copilot Copilot AI review requested due to automatic review settings May 29, 2025 02:40
@VSadov VSadov added test-enhancement Improvements of test source code runtime-async labels May 29, 2025
@VSadov VSadov requested a review from agocke May 29, 2025 02:40
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 29, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a conditional DisableProjectBuild setting to skip building async tests on configurations (mono, nativeaot, wasm) that aren’t yet supported.

  • Introduce a new <PropertyGroup> with a DisableProjectBuild conditioned on RuntimeFlavor, TestBuildMode, or TargetArchitecture.
  • Retain the existing unconditional DisableProjectBuild for overall runtime async NYI.
Comments suppressed due to low confidence (1)

src/tests/async/Directory.Build.targets:9

  • The unconditional <DisableProjectBuild> in the second PropertyGroup will override the conditional property above, effectively disabling builds for all configurations. Consider merging these into one PropertyGroup with an appropriate condition or removing the unconditional flag so supported configurations can build.
<DisableProjectBuild>true</DisableProjectBuild>

@VSadov
Copy link
Member Author

VSadov commented May 29, 2025

The reason why we cannot just exclude the tests from running is because in some cases just trying to build is enough to cause failures as the post-build tooling may not be familiar with runtime async patterns.

For an example on how wasm gets broken if tries to build these tests see: #115947 (comment)

I think it makes sense to not even build these tests on configs where we do not yet expect them to work.

@VSadov VSadov added area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 29, 2025
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@VSadov
Copy link
Member Author

VSadov commented May 29, 2025

/ba-g two failures in threading and loader look like known and unrelated.

@VSadov VSadov merged commit 1aa4568 into dotnet:main May 29, 2025
70 of 73 checks passed
@VSadov VSadov deleted the disAsync branch May 29, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants