-
Notifications
You must be signed in to change notification settings - Fork 1k
Skip unstable ListView UI tests #13514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR skips a set of unstable ListView UI tests to improve overall test reliability.
- Skips tests flagged as flaky due to known issues (Unstable unit test: System.Windows.Forms.UITests.ListViewTests.ListView_Group_NavigateKeyboard_SucceedsAsync #11328, Unstable unit test: System.Windows.Forms.UITests.ListViewTests.ListView_Tile_... #13291, Unstable unit test: System.Windows.Forms.UITests.ListViewTests.ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync #13288).
- Adds [ActiveIssue] and [SkipOnArchitecture] attributes to the affected test methods.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13514 +/- ##
===================================================
- Coverage 76.59837% 76.59165% -0.00673%
===================================================
Files 3230 3230
Lines 639165 639148 -17
Branches 47297 47295 -2
===================================================
- Hits 489590 489534 -56
- Misses 145993 146080 +87
+ Partials 3582 3534 -48
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ter_CheckBoxesAsync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that they block us more right now and they are not at all helping us. And we do not have the person power to fix them timely, so let's skip them for the time being.
Related #11328, #13291
Adding this test to the new synchronized collection does not resolve the instability
Proposed changes
Microsoft Reviewers: Open in CodeFlow