-
Notifications
You must be signed in to change notification settings - Fork 1k
Add unit test for GridToolTip.cs file #13533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13533 +/- ##
====================================================
+ Coverage 62.21083% 76.61323% +14.40240%
====================================================
Files 3213 3231 +18
Lines 638302 639199 +897
Branches 47201 47297 +96
====================================================
+ Hits 397093 489711 +92618
+ Misses 234153 145922 -88231
+ Partials 7056 3566 -3490
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces unit tests for the GridToolTip class to verify its functionality with respect to tooltip value setting, handling of null and empty strings, text truncation, resetting behavior, and handle creation.
- Added comprehensive tests covering various tooltip value scenarios
- Integrated handle creation validation through a Form-based test
public void GridToolTip_Reset() | ||
{ | ||
_toolTip.ToolTip = "abc"; | ||
_toolTip.Reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The 'GridToolTip_Reset' test expects the tooltip value to remain unchanged after calling Reset(). Consider adding a comment to clarify the intended behavior of Reset() to improve code clarity and maintainability.
Copilot uses AI. Check for mistakes.
...test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridInternal/GridToolTipTests.cs
Outdated
Show resolved
Hide resolved
...test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridInternal/GridToolTipTests.cs
Outdated
Show resolved
Hide resolved
...test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridInternal/GridToolTipTests.cs
Outdated
Show resolved
Hide resolved
...test/unit/System.Windows.Forms/System/Windows/Forms/PropertyGridInternal/GridToolTipTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related #13442
Proposed changes
Microsoft Reviewers: Open in CodeFlow