Update TreeView's TvnEndLabelEdit method to set label to null when no text has changed #13588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text has changed
LeafShi1
requested review from
ricardobossan,
Epica3055,
Copilot and
KlausLoeffelmann
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TreeView’s label edit handling to prevent exceptions when the text remains unchanged.
- Refactors TvnBeginLabelEdit by removing a redundant duplicate condition check.
- Updates TvnEndLabelEdit to pass null for the new label when the text is unchanged, preventing exception scenarios on Enter key presses.
Comments suppressed due to low confidence (1)
src/System.Windows.Forms/System/Windows/Forms/Controls/TreeView/TreeView.cs:2604
- The condition continues to use the original newText variable rather than the value passed via e.Label. To ensure that the node edit is only finished when a change has occurred, consider checking e.Label instead of newText.
if (newText is not null && !e.CancelEdit && node is not null)
src/System.Windows.Forms/System/Windows/Forms/Controls/TreeView/TreeView.cs
Outdated
Show resolved
Hide resolved
KlausLoeffelmann
previously approved these changes
Jun 13, 2025
…prove readability
Epica3055
approved these changes
Jun 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13588 +/- ##
===================================================
+ Coverage 76.60518% 76.60716% +0.00197%
===================================================
Files 3235 3236 +1
Lines 639321 639452 +131
Branches 47314 47319 +5
===================================================
+ Hits 489753 489866 +113
- Misses 145996 146065 +69
+ Partials 3572 3521 -51
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
LeafShi1
deleted the
Issue_13583_fix_add_judgement_before_NodeLabelEditEventArgs
branch
KlausLoeffelmann
pushed a commit
to KlausLoeffelmann/winforms
that referenced
this pull request
Jun 16, 2025
… text has changed (dotnet#13588) * Update TreeView's TvnEndLabelEdit method to set label to null when no text has changed
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/15725596969 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13583
Proposed changes
TvnEndLabelEditmethod to set label to null when no text has changedCustomer Impact
Regression?
Risk
Screenshots
Before
Pressing the Enter key when a TreeNode enters the edit state will cause an exception
After
When a TreeNode enters the edit state, press the Enter key, the node will exit the edit state
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow