Remaining Darkmode issues for Preview 6 #13610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KlausLoeffelmann
force-pushed
the
DarkModeFixTabListViewComboDgv
branch
from
465b110 to
8c8fedb
Compare
KlausLoeffelmann
force-pushed
the
DarkModeFixTabListViewComboDgv
branch
from
f640369 to
903cbe0
Compare
KlausLoeffelmann
added
area-DarkMode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13610 +/- ##
====================================================
+ Coverage 76.55974% 97.41138% +20.85163%
====================================================
Files 3252 1189 -2063
Lines 640748 353200 -287548
Branches 47429 5382 -42047
====================================================
- Hits 490555 344057 -146498
+ Misses 146663 8378 -138285
+ Partials 3530 765 -2765
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JeremyKuhne
approved these changes
Jun 17, 2025
| @@ -2545,6 +2557,8 @@ private int CompensateColumnHeaderResize(int columnIndex, bool columnResizeCance | |||
|
|
|||
| protected override unsafe void CreateHandle() | |||
| { | |||
| base.CreateHandle(); | |||
There was a problem hiding this comment.
This should have a comment that explains why it must come first.
| } | ||
|
|
||
| #pragma warning disable WFO5001 | ||
| private void ApplyDarkModeOnDemand() |
There was a problem hiding this comment.
Same comment as before, ApplyDarkMode better reflects what this method does.
There was a problem hiding this comment.
Will add all mentioned issue to the list as soon as I have done high prio tasks.
This was referenced Jun 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes remaining dark mode issues for Preview 6 in
Microsoft Reviewers: Open in CodeFlow