Skip to content

Back-port DarkMode Fixes to Preview 6. #13611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Jun 18, 2025

This PR cherry-picks a series of Darkmode fixes from the main branch to the Preview 6 branch.

Microsoft Reviewers: Open in CodeFlow

@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner June 18, 2025 02:02
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label Jun 18, 2025
@KlausLoeffelmann KlausLoeffelmann changed the base branch from main to release/10.0-preview6 June 18, 2025 02:02
@KlausLoeffelmann KlausLoeffelmann enabled auto-merge (rebase) June 18, 2025 02:18
merriemcgaw
merriemcgaw previously approved these changes Jun 18, 2025
Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

codecov bot commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 22.36543% with 1024 lines in your changes missing coverage. Please review.

Project coverage is 76.50064%. Comparing base (380e851) to head (ee3d8e3).
Report is 8 commits behind head on release/10.0-preview6.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           release/10.0-preview6      #13611         +/-   ##
===============================================================
- Coverage               76.60904%   76.50064%   -0.10840%     
===============================================================
  Files                       3236        3246         +10     
  Lines                     639448      640511       +1063     
  Branches                   47318       47422        +104     
===============================================================
+ Hits                      489875      489995        +120     
- Misses                    146048      146985        +937     
- Partials                    3525        3531          +6     
Flag Coverage Δ
Debug 76.50064% <22.36543%> (-0.10840%) ⬇️
integration 18.48086% <9.40106%> (-0.04471%) ⬇️
production 50.86361% <22.36543%> (-0.15031%) ⬇️
test 97.41244% <ø> (-0.00039%) ⬇️
unit 48.27243% <21.98635%> (-0.14931%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann KlausLoeffelmann merged commit 480f1fb into dotnet:release/10.0-preview6 Jun 18, 2025
8 checks passed
@KlausLoeffelmann KlausLoeffelmann deleted the BackPortDarkModeFixes branch June 18, 2025 04:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-DarkMode Issues relating to Dark Mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants