fix #13624 DemoConsole app: An exception pops up when focusing on "Type Here" in contextMenuStrip under DarkMode #13635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13624
Root cause
When in DarkMode we use ToolStripSystemDarkModeRenderer do the rendering work.
Type here
is not an actual ToolStripItem, so thenull
value pass to ToolStripArrowRenderEventArgsSo not only in
DarkMode
, but also in normal color mode, e.Item inDrawArrow
is null, but theDrawArrow
method ofToolStripRenderer
makes a null judgment on e.Item, while ToolStripRenderer.cs does not, so this problem occurs.Proposed changes
Before
Exception.mp4
After
no Exception
Test methodology
Microsoft Reviewers: Open in CodeFlow