-
Notifications
You must be signed in to change notification settings - Fork 758
Avoid touching the SCC as much as possible during stack walk #21972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a4b9ec
to
67784cd
Compare
baac1c4
to
b98dc99
Compare
@dmitripivkine Please take a look at the GC changes. What I intend is to flush the appropriate class loader cache when a class is unloaded. I may have the flush a bit too deep if classes can only be unloaded when their loaded is unloaded. What about anon classes? IIRC, they get unloaded piecemeal. |
fc04d09
to
9aab46b
Compare
Classes are unloaded on class loader basis (except Anonymous), there is no case some classes can be unloaded but entire class loader not. So I think flushing should be done once. I assume it should be done before class loader unloading (cleanup). Anonymous classes can be unloaded individually, but there is a trick. Anonymous class loader is just technical storage for Anonymous classes (and it can not be unloaded by design). Each Anonymous class however has pointer to its parent class loader (not an Anonymous one). |
jenkins compile xlinux jdk17 |
Thanks GAC, we are going to do some perf runs on it. |
jenkins compile xlinux jdk17 |
4565bf5
to
7360339
Compare
jenkins test sanity.functional win jdk8 |
jenkins test amac sanity,extended.functional amac jdk17 |
jenkins test sanity,extended.functional amac jdk17 |
Consistent crash here:
|
Failures seem to be related to use of the |
dff3748
to
aa353bf
Compare
Cache localmap/stackmap/argbits to avoid walking bytecodes. Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
jenkins line endings check |
jenkins test sanity,extended.functional xlinux jdk17 |
jenkins test sanity,extended.functional zlinux jdk21 |
The logic was reversed. Related: eclipse-openj9#21972 Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
Cache localmap/stackmap/argbits to avoid walking bytecodes.
Related: #21812
This feature is disabled by default. Enable with
-XX:+CacheMaps