Skip to content

Improve IllegalAccessError with specific exception messages #22118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

JasonFengJ9
Copy link
Member

Improve IllegalAccessError with specific exception messages

The improved exception message looks like:

Caused by: java.lang.IllegalAccessError: class org/openj9/test/illegalAccessError/ExtendsDefaultVisibility (in unnamed module 0x0000000000000000 from loader java/net/URLClassLoader) cannot access its superclass org/openj9/test/illegalAccessError/DefaultVisibility (in unnamed module 0x0000000000000000 from loader jdk/internal/loader/ClassLoaders$AppClassLoader)

Added a test.

Java 8 zOS personal build works.

Signed-off-by: Jason Feng fengj@ca.ibm.com

The improved exception message looks like:
Caused by: java.lang.IllegalAccessError: class
org/openj9/test/illegalAccessError/ExtendsDefaultVisibility (in unnamed
module 0x0000000000000000 from loader java/net/URLClassLoader) cannot
access its superclass
org/openj9/test/illegalAccessError/DefaultVisibility (in unnamed module
0x0000000000000000 from loader
jdk/internal/loader/ClassLoaders$AppClassLoader)
Added a test.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@keithc-ca
Copy link
Contributor

Jenkins test sanity.functional win jdk8,jdk21

@JasonFengJ9
Copy link
Member Author

15:19:55 ERROR: Cannot delete workspace :Unable to delete 'F:\Users\jenkins\workspace\Build_JDK8_x86-64_windows_Personal\openssl\NUL'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.

Infra error

@keithc-ca
Copy link
Contributor

Infra error

I restarted that job.

@keithc-ca
Copy link
Contributor

15:19:55 ERROR: Cannot delete workspace :Unable to delete 'F:\Users\jenkins\workspace\Build_JDK8_x86-64_windows_Personal\openssl\NUL'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.

Infra error

Depending on the tools used to delete the workspace, it may never succeed: NUL is a special name on Windows; it may need to use cygwin rm.

@JasonFengJ9
Copy link
Member Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_sanity.functional_x86-64_windows_Personal_testList_1/489/consoleFull

17:07:28  Testing: testJSR292Permissions
17:07:28  Test start time: 2025/06/19 17:06:54 Eastern Standard Time

17:07:28  Test result: FAILED
17:07:28  Output from test:
17:07:28   [ERR] java.lang.NoClassDefFoundError: org.objectweb.asm.ClassWriter
17:07:28   [ERR] 	at com.ibm.j9.jsr292.indyn.TestJSR292.createIndyClass(TestJSR292.java:54)
17:07:28   [ERR] 	at com.ibm.j9.jsr292.indyn.TestJSR292.access$000(TestJSR292.java:39)
17:07:28   [ERR] 	at com.ibm.j9.jsr292.indyn.TestJSR292$CustomClassLoader.findClass(TestJSR292.java:79)
17:07:28   [ERR] 	at java.lang.ClassLoader.loadClassHelper(ClassLoader.java:958)
17:07:28   [ERR] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:903)
17:07:28   [ERR] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:886)
17:07:28   [ERR] 	at com.ibm.j9.jsr292.indyn.TestJSR292.testJSR292Perm(TestJSR292.java:47)
17:07:28   [ERR] 	at com.ibm.j9.jsr292.indyn.TestJSR292.main(TestJSR292.java:42)
17:07:28   [ERR] Caused by: java.lang.ClassNotFoundException: org.objectweb.asm.ClassWriter
17:07:28   [ERR] 	at java.net.URLClassLoader.findClass(URLClassLoader.java:590)
17:07:28   [ERR] 	at java.lang.ClassLoader.loadClassHelper(ClassLoader.java:958)
17:07:28   [ERR] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:903)
17:07:28   [ERR] 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
17:07:28   [ERR] 	at java.lang.ClassLoader.loadClass(ClassLoader.java:886)
17:07:28   [ERR] 	... 8 more

17:07:28  Number of FAILED tests: 1 out of 7
17:07:28  
17:07:28  ---SUMMARY OF FAILED TESTS---
17:07:28  testJSR292Permissions
17:07:28  -----------------------------
17:07:28  
17:07:28  -----------------------------------
17:07:28  cmdLineTester_J9securityTests_SE80_0_FAILED

This seems a machine/network issue. It is not related to this PR.

@keithc-ca keithc-ca merged commit f91146b into eclipse-openj9:master Jun 20, 2025
5 of 7 checks passed
@JasonFengJ9 JasonFengJ9 deleted the errormsgV2 branch June 20, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants