-
Notifications
You must be signed in to change notification settings - Fork 327
Towards immutable BindingsMap in Java #13315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ GUI Checks ResultsSummary
See individual check results for more details. |
|
JaroslavTulach
commented
Jun 18, 2025
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the
getState()
method and theupdateState(...)
methods turn - the
BindingsMapBase
into fully transactional data structure - if the
updator
function passed intoupdateState
is pure function fromState
toState
then:- no state update can be lost
- the final state includes all performed updates
- no matter how many threads is trying to update the binding map
GregoryTravis
approved these changes
Jun 20, 2025
Akirathan
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine/runtime-compiler/src/main/scala/org/enso/compiler/data/BindingsMap.scala
Outdated
Show resolved
Hide resolved
engine/runtime-compiler/src/main/scala/org/enso/compiler/data/BindingsMap.scala
Show resolved
Hide resolved
Akirathan
reviewed
Jun 20, 2025
engine/runtime-compiler/src/main/java/org/enso/compiler/data/BindingsMapBase.java
Show resolved
Hide resolved
Co-authored-by: Pavel Marek <pavel.marek@enso.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Initial rewrite of
BindingsMap
to:State
that can be replaced at once in the best tradition of TransactionalDataStructuresBindingsMapBase
superclassThe goal is:
BindingsMap
functionality unchangedBindingsMapBase
to fully transactional structureLater also:
updateState
calls are really "pure functions"Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,