OSS: add Build Event Service proto to buck2 #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This split the Google API protobufs into it's own crate. In a future diff, we shall introduce newer crates which depends on this crate directly.
We intend to use this as a replacement for the existing Scribe protocol to send telementry data (BuckEvent) to a remote server.
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
|
Technically, the BES proto is also part of the googleapis repository, but I think it's worth splitting into a separate crate to avoid build cache churn. cc: @avdv @aherrmann |
Add a Buck2 specific field to unblock BuckEvent OSS remote client development. This field is created in accordance to the discussion with Google's DevTools team in googleapis/googleapis#988 and should be generic enough for all build tools (including Buck2) to implement.
sluongng
force-pushed
the
sluongng/bes-proto
branch
from
0326148 to
11f9b21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stack of 3 commits/diffs that add Bazel's Build Event Service(BES) proto
to Buck2. Note that the client implementation is not included in this stack.
In the BES proto, we made a Buck2-specific change following the discussion with Google's
DevTools team in googleapis/googleapis#988. The change added a new
generic
build_tool_eventmessage to theBuildEventproto, which allows us tosend BuckEvent messages as a part of the Build Event Service.
The change is backward compatible with existing server implementations and can also be used
by other build systems that want to send their own events to the BES.