Handle dataclass field kw_only overrides #566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Nice, thanks! |
rchen152
reviewed
Jun 25, 2025
| field.as_param( | ||
| &name, | ||
| field_flags.is_set(&DataclassKeywords::DEFAULT), | ||
| field_flags |
There was a problem hiding this comment.
You can change the default value passed to is_set like so:
field_flags.is_set(&(DataclassKeywords::KW_ONLY.0, kw_only)),
No need for a new get_explicit method.
There was a problem hiding this comment.
I'll address this in the internal version of the PR
|
@yangdanny97 merged this pull request in f3503d9. |
vagabond-0
pushed a commit
to vagabond-0/pyrefly
that referenced
this pull request
Jun 27, 2025
Summary: ## Description This PR allows for field-level overrides to set `kw_only=False` for a dataclass when the class has `kw_only` set to `True`. ## Relevant Issue Closes facebook#494. ## Testing Instructions To test this PR manually, create a Python script like ``` from dataclasses import dataclass, field dataclass(kw_only=True) class SomeClass: x: int = field(kw_only=False) SomeClass(x=1) SomeClass(1) ``` and run `pyrefly check`. Verify that no errors are generated. Note: this PR does not handle cases where there are mixed positional and keyword-only arguments; that will be handled in a follow-up PR (related issue: facebook#493). Pull Request resolved: facebook#566 Test Plan: Imported from GitHub, without a `Test Plan:` line. Rollback Plan: Reviewed By: ndmitchell Differential Revision: D77305257 Pulled By: yangdanny97 fbshipit-source-id: 7dcc8d49b9d25a35f4479fc5cca9c89b834f79ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows for field-level overrides to set
kw_only=Falsefor a dataclass when the class haskw_onlyset toTrue.Relevant Issue
Closes #494.
Testing Instructions
To test this PR manually, create a Python script like
and run
pyrefly check. Verify that no errors are generated.Note: this PR does not handle cases where there are mixed positional and keyword-only arguments; that will be handled in a follow-up PR (related issue: #493).