Add codegen for DimensionType diffing #52242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77234061 |
|
This pull request was exported from Phabricator. Differential Revision: D77234061 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jun 25, 2025
Summary: Pull Request resolved: facebook#52242 Codegen supports `DimensionType` props which represents a YGValue. This diff adds a conversion to `folly::dynamic` supporting all the existing value types `YGValue` can represent. This completes codegen support for all allowed `ReservedPropTypeAnnotation` prop types. Changelog: [Internal] Differential Revision: D77234061
added 2 commits
June 25, 2025 05:36
Summary: Add support for converting string and int32 enum types to `folly::dynamic` and generating the correct property diffing for it conditionally adding the prop value to the prop diff result. This diff updates the template to convert the enum back to the original string representation provided from the JS side based on the current generated C++ enum value. The string enum re-uses the existing `toString` conversion. The number enum generates the switch-case mapping required to map back the C++ enum value to the original value assigned to it. Changelog: [Internal] Differential Revision: D77234070
Summary: Codegen supports `DimensionType` props which represents a YGValue. This diff adds a conversion to `folly::dynamic` supporting all the existing value types `YGValue` can represent. This completes codegen support for all allowed `ReservedPropTypeAnnotation` prop types. Changelog: [Internal] Differential Revision: D77234061
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jun 25, 2025
Summary: Codegen supports `DimensionType` props which represents a YGValue. This diff adds a conversion to `folly::dynamic` supporting all the existing value types `YGValue` can represent. This completes codegen support for all allowed `ReservedPropTypeAnnotation` prop types. Changelog: [Internal] Differential Revision: D77234061
|
This pull request was exported from Phabricator. Differential Revision: D77234061 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jun 25, 2025
Summary: Codegen supports `DimensionType` props which represents a YGValue. This diff adds a conversion to `folly::dynamic` supporting all the existing value types `YGValue` can represent. This completes codegen support for all allowed `ReservedPropTypeAnnotation` prop types. Changelog: [Internal] Differential Revision: D77234061
|
This pull request has been merged in 8c806ec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Codegen supports
DimensionTypeprops which represents a YGValue. This diff adds a conversion tofolly::dynamicsupporting all the existing value typesYGValuecan represent.This completes codegen support for all allowed
ReservedPropTypeAnnotationprop types.Changelog: [Internal]
Differential Revision: D77234061