Skip to content

feat: deployment backend prototype based on Nelm (main) #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from

Conversation

juev
Copy link
Contributor

@juev juev commented Jun 6, 2025

Overview

Trying to use nelm as a replacement for helm

What this PR does / why we need it

These are improvements to the existing PR #594

ldmonster and others added 23 commits May 30, 2025 13:53
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Ilya Lesikov <ilya@lesikov.com>
Signed-off-by: Ilya Lesikov <ilya@lesikov.com>
Signed-off-by: Ilya Lesikov <ilya@lesikov.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…on of labels

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…tation

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…er implementation

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
… from release annotations

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…ues method

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…e management and label handling

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
… release management

- Introduced NelmActions interface for better abstraction of release operations.
- Refactored NelmClient to utilize the new interface for actions like ReleaseGet, ReleaseInstall, and others.
- Updated tests to accommodate the new structure and ensure functionality remains intact.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…s purpose and behavior

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…d code organization

- Added missing import for utils in nelm_test.go.
- Changed map types from `map[string]interface{}` to `map[string]any` for better type safety.
- Removed unused test client creation functions in nelm_test.go.
- Improved release names handling in ListReleasesNames method in nelm.go.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Updated logging to include chart name when release name is empty, improving clarity in logs.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…easesNames method

- Simplified ListReleasesNames by removing the check for empty release names, as it is no longer needed.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Replaced string concatenation with strings.Builder for improved performance in the Render method of NelmClient.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Updated NewNelmClient to eliminate the actions parameter, defaulting to DefaultNelmActions.
- Adjusted tests in nelm_test.go to set actions after client creation for consistency.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Changed nelmLog.Default to nelmLog.DefaultNull in NewNelmClient for improved logging behavior.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
- Updated InitHelmClientFactory to initialize Nelm client when USE_NELM environment variable is set.
- Enhanced tests to verify detection of Nelm client and its initialization.

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
@juev juev self-assigned this Jun 6, 2025
@juev juev added enhancement New feature or request go Pull requests that update Go code labels Jun 6, 2025
juev added 4 commits June 9, 2025 09:35
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
juev added 2 commits June 10, 2025 11:29
….Builder

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…ng in Render method

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
juev added 7 commits June 10, 2025 12:12
…ot found

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…um is not found

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…lient actions

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…er integration

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
…lOptions and improve error handling in GetReleaseChecksum

Signed-off-by: Evsyukov Denis <denis.evsyukov@flant.com>
@juev juev force-pushed the feature/nelm branch 2 times, most recently from 9862787 to 7157248 Compare June 11, 2025 09:41
ldmonster added 18 commits June 17, 2025 10:38
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
…nelm

Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants