Skip to content

Bug Fix: Graceful Handling of Missing Helm Releases in Unmanaged State #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025

Conversation

riptide-01
Copy link
Contributor

@riptide-01 riptide-01 commented Jun 10, 2025

Overview

Fixed an issue where re-enabling the module in an unmanaged state caused the system to crash with a release: not found error. The fix adds proper handling for this case, allowing reconciliation to proceed normally.

What this PR does / why we need it

When re-enabling the module in an unmanaged state, the system would fail with a critical error in deckhouse main queue and halt reconciliation:

ModuleRun:main:runtime-audit-engine:doStartup:OperatorStartup:failures 7
run helm install: get release label failed
helm get failed: release: not found

Root Cause:

  • The Helm release lookup operation was treating "not found"
  • Error propagation was interrupting the entire reconciliation queue

Solution:

  • Added specific handling for "not found" errors
  • Modified the error handling logic to continue reconciliation when: The release is not found AND the cluster is in unmanaged state
  • Maintained existing behavior for actual error cases

Special notes for your reviewer

  • Changes tested on local cluster manually

@riptide-01 riptide-01 self-assigned this Jun 10, 2025
@riptide-01 riptide-01 added bug Something isn't working go Pull requests that update Go code labels Jun 10, 2025
@riptide-01 riptide-01 modified the milestone: 1.3.11 Jun 10, 2025
@riptide-01 riptide-01 changed the title fix inmanaged bug Bug Fix: Graceful Handling of Missing Helm Releases in Unmanaged State Jun 11, 2025
@riptide-01 riptide-01 force-pushed the feature/helm-unmanaged-bug branch 2 times, most recently from 0ed8001 to 717403f Compare June 11, 2025 07:34
Smyslov Maxim added 2 commits June 11, 2025 10:38
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>

linter recommends

Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>

aa

Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
@riptide-01 riptide-01 force-pushed the feature/helm-unmanaged-bug branch from 717403f to ab2df11 Compare June 11, 2025 07:38
Smyslov Maxim added 2 commits June 11, 2025 13:51
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>

fff

Signed-off-by: Smyslov Maxim <maksim.smyslov@flant.com>
@riptide-01 riptide-01 requested a review from ldmonster June 23, 2025 07:11
@ldmonster ldmonster merged commit 0724bf3 into main Jun 23, 2025
8 of 9 checks passed
@ldmonster ldmonster deleted the feature/helm-unmanaged-bug branch June 23, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants