Skip to content

mimirtool: Add chunk digest flag to remote-read dump command #11734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: dimitar/mimirtool/multiple-selectors-remote-read
Choose a base branch
from

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Jun 13, 2025

This is being built upon #11733 because I've had these changes locally on a branch for a while now

Summary

Add --chunk-digest flag to remote-read dump command to print chunk metadata (min time, max time, checksum) instead of decoding samples. This is useful for inspecting chunk-level information and data integrity verification.

Here is sample output

{__name__="up", asserts_env="dev-us-central-0", cluster="dev-us-central-0", container="compactor", instance="compactor-1:compactor:http-metrics", job="mimir-dev-14/compactor", namespace="mimir-dev-14", pod="compactor-1"} chunk_0 min_time=1734507020045 max_time=1734507905045 checksum=79cae89c080017ff2378bbb953d2976b
{__name__="up", asserts_env="dev-us-east-0", cluster="dev-us-east-0", container="compactor", instance="compactor-1:compactor:http-metrics", job="cortex-dev-05/compactor", namespace="cortex-dev-05", pod="compactor-1"} chunk_0 min_time=1734507022648 max_time=1734507907648 checksum=dfa1facd5ae3f808e0766245f2de5bfc
{__name__="up", asserts_env="dev-us-east-0", cluster="dev-us-east-0", container="compactor", instance="compactor-1:compactor:http-metrics", job="mimir-dev-15/compactor", namespace="mimir-dev-15", pod="compactor-1"} chunk_0 min_time=1734507015654 max_time=1734507900654 checksum=55a287a1c576641d463f6610c49a9b54

@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/mimirtool/chunk-digest branch from 7dc4a22 to 187fe81 Compare June 13, 2025 20:34
@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/mimirtool/multiple-selectors-remote-read branch from a880c41 to 8a5f264 Compare June 13, 2025 20:38
Copy link
Contributor

github-actions bot commented Jun 13, 2025

@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/mimirtool/chunk-digest branch from 03ebec2 to 0a84614 Compare June 13, 2025 20:39
@dimitarvdimitrov dimitarvdimitrov changed the title Mimirtool: Add chunk digest flag to remote-read dump command mimirtool: Add chunk digest flag to remote-read dump command Jun 13, 2025
@dimitarvdimitrov dimitarvdimitrov marked this pull request as ready for review June 13, 2025 20:39
@dimitarvdimitrov dimitarvdimitrov requested review from tacole02 and a team as code owners June 13, 2025 20:39
@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/mimirtool/chunk-digest branch 2 times, most recently from 1e8fc55 to 63351fd Compare June 13, 2025 21:25
@dimitarvdimitrov dimitarvdimitrov force-pushed the dimitar/mimirtool/chunk-digest branch from d3e1c85 to 8f70ae2 Compare June 13, 2025 21:37
@@ -59,7 +59,7 @@
* [ENHANCEMENT] Distributor: Trace when deduplicating a metric's samples or histograms. #11159 #11715
* [ENHANCEMENT] Store-gateway: Retry querying blocks from store-gateways with dynamic replication until trying all possible store-gateways. #11354 #11398
* [ENHANCEMENT] Mimirtool: Support multiple `--selector` flags in remote read commands to send multiple queries in a single protobuf request, leveraging the remote read protocol's native batching capabilities. Added `--use-chunks` flag to control response type preference (chunked streaming vs sampled). #11733
* [ENHANCEMENT] Mimirtool: Add `--chunk-digest` flag to `remote-read dump` command to print chunk metadata (min time, max time, checksum) instead of decoding samples. Useful for inspecting chunk-level information and data integrity verification. #11734
* [ENHANCEMENT] Mimirtool: Add `--chunk-digest` flag to `remote-read dump` command to print chunk metadata (min time, max time, SHA256 checksum) instead of decoding samples. Useful for inspecting chunk-level information and data integrity verification. #11734
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [ENHANCEMENT] Mimirtool: Add `--chunk-digest` flag to `remote-read dump` command to print chunk metadata (min time, max time, SHA256 checksum) instead of decoding samples. Useful for inspecting chunk-level information and data integrity verification. #11734
* [ENHANCEMENT] Mimirtool: Add the `--chunk-digest` flag to the`remote-read dump` command to print chunk metadata (minimum time, maximum time, and SHA256 checksum) instead of decoding samples. This flag is useful for inspecting chunk-level information and data integrity verification. #11734

@@ -577,7 +577,7 @@ Additionally, you can control the response format using the `--use-chunks` flag:

- `--use-chunks=true` (default): Requests chunked streaming response for better performance with large datasets
- `--use-chunks=false`: Requests traditional sampled response format
- `--chunk-digest`: Print chunk metadata (min time, max time, checksum) instead of decoding samples when using chunked responses. Can only be combined with `--use-chunks`
- `--chunk-digest`: Print chunk metadata (min time, max time, SHA256 checksum) instead of decoding samples when using chunked responses. Can only be combined with `--use-chunks`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `--chunk-digest`: Print chunk metadata (min time, max time, SHA256 checksum) instead of decoding samples when using chunked responses. Can only be combined with `--use-chunks`
- `--chunk-digest`: Prints chunk metadata (minimum time, maximum time, andSHA256 checksum) instead of decoding samples when using chunked responses. You can only combine this flag with `--use-chunks`.

@zenador
Copy link
Contributor

zenador commented Jul 10, 2025

🤖 Automated comment

The CHANGELOG has just been cut to prepare for the next release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG.md document. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants