MQE: ensure pooled slices not reused #11741
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
added
the
changelog-not-needed
charleskorn
force-pushed
the
charleskorn/ensure-pooled-slices-not-reused
branch
from
82cdf96 to
83ab394
Compare
charleskorn
force-pushed
the
charleskorn/ensure-pooled-slices-not-reused
branch
from
83ab394 to
4ee2a3b
Compare
charleskorn
force-pushed
the
charleskorn/ensure-pooled-slices-not-reused
branch
from
4ee2a3b to
e9db1f2
Compare
charleskorn
force-pushed
the
charleskorn/ensure-pooled-slices-not-reused
branch
from
6f49f33 to
e0ac2b2
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces a linter to catch issues like #11690.
It does this by changing
LimitingBucketedPool.Putto return anilslice, and adding a linter to enforce that this return value is used.This isn't foolproof. For example, the linter doesn't enforce that the return value is stored in the first argument to
Put(eg.b = pool.Put(a, memoryConsumptionTracker)isn't flagged).Which issue(s) this PR fixes or relates to
#11690
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.