generate-otlp: run in build image #11841
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitarvdimitrov
added
the
changelog-not-needed
This makes it easier to manage the dependencies of the script and upgrade them only in a single place Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/build/actions/run-generate-otlp-in-build-image
branch
from
b7b4cca to
04bbb6c
Compare
dimitarvdimitrov
requested review from
wilfriedroset,
vaxvms,
bubu11e and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to manage the dependencies of the script and upgrade them only in a single place. The build image already contains these dependencies. For this I also had to move the target into the targets that run in a build image.
example run https://github.com/grafana/mimir/actions/runs/15878851471/job/44773419103 and PR #11860 (the point is that the PR's CI passes and that the GH action completes)