Skip to content

Fix misleading "production-ready" description of small.yaml #11864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

dimitarvdimitrov
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov commented Jun 25, 2025

Summary

  • Fixed misleading "production-ready" description in small.yaml and related documentation
  • Clarified that small.yaml is for higher scale than defaults but not suitable for high-availability production use
  • Updated documentation to distinguish between small.yaml (higher scale) and large.yaml (production HA)

The small.yaml values file configured single replicas for critical
components like gateway, query-frontend, querier, and ruler, creating
single points of failure. Updated comments and documentation to clarify
that small.yaml is suitable for higher scale than defaults but not for
high-availability production deployments.

Changes:
- Updated small.yaml header comment to clarify it's not for HA production use
- Fixed documentation table description in helm-chart.md
- Updated values.yaml comments to distinguish between small.yaml (higher scale) and large.yaml (production HA)
@dimitarvdimitrov dimitarvdimitrov requested review from tacole02 and a team as code owners June 25, 2025 15:12
@dimitarvdimitrov dimitarvdimitrov added the changelog-not-needed PRs that don't need a CHANGELOG.md entry label Jun 25, 2025
Copy link
Contributor

github-actions bot commented Jun 25, 2025

💻 Deploy preview deleted.

dimitarvdimitrov and others added 2 commits June 26, 2025 18:03
Co-authored-by: Taylor C <41653732+tacole02@users.noreply.github.com>
@dimitarvdimitrov dimitarvdimitrov merged commit 503480c into main Jun 27, 2025
35 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/helm/fix-small-yaml-comment branch June 27, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-not-needed PRs that don't need a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants