Skip to content

Use convertName in codegen plugin #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 23, 2025

Conversation

adrtivv
Copy link
Contributor

@adrtivv adrtivv commented Jun 9, 2025

Description

Added the convertName function from the @graphql-codegen/visitor-plugin-common package
to generate type references that match the default types generated by graphql-codegen's typescript plugin.
https://discord.com/channels/489127045289476126/1172532079603494982/1381335488199262239

Performance impact

unknown

Security impact

unknown

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Jun 9, 2025
@adrtivv adrtivv force-pushed the graphql_codegen_grafast branch from 712063d to 1e3b85a Compare June 9, 2025 14:50
Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: ff7b1c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-codegen-grafast Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrtivv adrtivv force-pushed the graphql_codegen_grafast branch from 1e3b85a to 9bf10dd Compare June 9, 2025 14:56
adrtivv and others added 4 commits June 23, 2025 15:33
Added the `convertName` function from the
``@graphql-codegen/visitor-plugin-common` package
to generate type references that match the default
types generated by graphql-codegen's `typescript`
plugin.
@benjie benjie force-pushed the graphql_codegen_grafast branch from 15f3ace to 15bafa1 Compare June 23, 2025 14:34
benjie
benjie previously approved these changes Jun 23, 2025
@github-project-automation github-project-automation bot moved this from 🌳 Triage to 🌱 In Progress in V5.0.0 Jun 23, 2025
@benjie benjie changed the title fix incorrect codegen type generation Use convertName in codegen plugin Jun 23, 2025
…compatibility with non-standard configurations/field names.
@benjie benjie merged commit e4f3348 into graphile:main Jun 23, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 🌱 In Progress to ✅ Done in V5.0.0 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants